HDDS-15800. Move mocks out of TestUpgradeFinalizerActions#10700
Closed
adoroszlai wants to merge 1 commit into
Closed
HDDS-15800. Move mocks out of TestUpgradeFinalizerActions#10700adoroszlai wants to merge 1 commit into
adoroszlai wants to merge 1 commit into
Conversation
adoroszlai
added
test
code-cleanup
Contributor
|
Thanks for working on this. This code has all been deleted on the ZDU branch which should be merged in the coming weeks. Should we still proceed with this change? |
Contributor
Author
In that case it's not necessary. Thanks for checking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor
TestUpgradeFinalizerActions:MockLayoutFeature,MockLayoutVersionManagerto be top-level classes.MockUpgradeFinalizerandMockFailingUpgradeActionare unused, can be deleted withTestUpgradeFinalizerActions.https://issues.apache.org/jira/browse/HDDS-15800
How was this patch tested?
https://github.com/adoroszlai/ozone/actions/runs/29034526852