HDDS-14759. Local Empty file is written and retained even when key write fails

[anuragp010]

What changes were proposed in this pull request?

The current behaviour of ozone sh key get /path/to/key localFile when reading from the key fails with an IOException or RuntimeException, results in an empty file, localFile, being created. This file doesn't contain any data and can be deleted.

This PR ensures the empty file created in the above scenario is deleted.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14759

How was this patch tested?

Made with Claude Code.

1. Newly added Unit Tests.

2. Functional Validation:

Success Scenario:

Failure Scenario:

[adoroszlai]

Thanks @anuragp010 for the patch.

[sarvekshayr]

Thanks @anuragp010 for the fix.

Please address the minor nits in test class.

[anuragp010]

Thanks @adoroszlai and @sarvekshayr for the review comments, I have addressed them.

[sarvekshayr]

Thanks for updating the patch. LGTM.

[sarvekshayr]

Thanks @anuragp010 for the patch and @adoroszlai for the review.

[adoroszlai]

@anuragp010 Please share text as text, not screenshots. Plain text makes it easier to

• read (especially for those with visual impairments)
• reference (e.g. quote)
• search

It also reduces size to be stored by GitHub.

Sharing code can be even better by using permalink URLs.

[anuragp010]

@anuragp010 Please share text as text, not screenshots. Plain text makes it easier to

• read (especially for those with visual impairments)
• reference (e.g. quote)
• search

It also reduces size to be stored by GitHub.

Sharing code can be even better by using permalink URLs.

I understand. Will do. Thanks @adoroszlai.