HDDS-15848. Add new upgrade action annotations for component versions#10744
Draft
errose28 wants to merge 1 commit into
Draft
HDDS-15848. Add new upgrade action annotations for component versions#10744errose28 wants to merge 1 commit into
errose28 wants to merge 1 commit into
Conversation
(cherry picked from commit 3541c6c)
errose28
added
the
zdu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The existing upgrade action annotations only had layout feature fields. Annotation fields cannot be an interface like
ComponentVersion, so create a new set of annotations to be used for upgrade actions mapped to ComponentVersions going forward. The annotations were given more descriptive names as follows:On the ZDU branch Recon's upgrade actions had been switched from LayoutFeature to ComponentVersion since it did not use both versions simultaneously. This means Recon now only needs
ReconUpgradeActionForVersionand noReconUpgradeActionForLayoutFeaturewas created.Upgrade action providers were modified to load both annotations.
What is the link to the Apache JIRA
HDDS-15848
How was this patch tested?
Unit tests for the new annotations with mocked upgrade actions were added since there are currently no real upgrade actions mapped to ComponentVersions. Once there are actions added for new versions the mocks can be removed, potentially as part of HDDS-14754. Existing tests for actions mapped to layout features should continue to pass.
Pending CI on my fork