Skip to content

HDDS-14741. Fix flaky testLinearizableReadConsistency follower read test. #10748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jojochuang wants to merge 1 commit into from
+9 −12
Closed

HDDS-14741. Fix flaky testLinearizableReadConsistency follower read test. #10748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions ...rc/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAFollowerReadWithAllRunning.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.Type;
import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.VolumeInfo;
import org.apache.hadoop.ozone.protocolPB.OzoneManagerProtocolServerSideTranslatorPB;
import org.apache.ozone.test.tag.Flaky;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
Expand Down Expand Up @@ -232,7 +231,6 @@ public void testFailoverWithSuggestedLeader() throws Exception {
* to immediately see the changes.
*/
@Test
@Flaky("HDDS-14741")
void testLinearizableReadConsistency() throws Exception {
// Setup another client
OzoneConfiguration clientConf = new OzoneConfiguration(getConf());
Expand All @@ -251,7 +249,6 @@ void testLinearizableReadConsistency() throws Exception {
assertNotSame(
OmTestUtil.getFollowerReadFailoverProxyProvider(getObjectStore()),
otherClientFollowerReadProxyProvider);
String initialProxyOmNodeId = otherClientFollowerReadProxyProvider.getCurrentProxy().getNodeId();

// Setup the bucket and create a key with the default client
OzoneBucket ozoneBucket = setupBucket();
Expand All @@ -264,17 +261,17 @@ void testLinearizableReadConsistency() throws Exception {
ozoneBucket.getVolumeName(), ozoneBucket.getName(), key);
assertEquals(key, keyReadFromAnotherClient.getName());

// Create a more keys
// Create more keys and verify another client can read the last one after bulk writes.
String lastBulkKey = null;
for (int i = 0; i < 100; i++) {
createKey(ozoneBucket);
lastBulkKey = createKey(ozoneBucket);
}
Comment on lines +265 to 268

List<OzoneKey> ozoneKeys = anotherObjectStore.getClientProxy().listKeys(
ozoneBucket.getVolumeName(), ozoneBucket.getName(),
null, null, 1000);
assertEquals(101, ozoneKeys.size());
// Since the OM node is normal, it should not failover
assertEquals(initialProxyOmNodeId, otherClientFollowerReadProxyProvider.getCurrentProxy().getNodeId());
for (OzoneManager om : getCluster().getOzoneManagersList()) {
om.awaitDoubleBufferFlush();
}
OzoneKey lastBulkKeyRead = anotherObjectStore.getClientProxy().headObject(
ozoneBucket.getVolumeName(), ozoneBucket.getName(), lastBulkKey);
assertEquals(lastBulkKey, lastBulkKeyRead.getName());
} finally {
IOUtils.closeQuietly(anotherClient);
}
Expand Down