Skip to content

HDDS-16127. Document that OmKeyInfo holds a single key version - #11018

Open
chihsuan wants to merge 3 commits into
apache:masterfrom
chihsuan:HDDS-16127
Open

HDDS-16127. Document that OmKeyInfo holds a single key version#11018
chihsuan wants to merge 3 commits into
apache:masterfrom
chihsuan:HDDS-16127

Conversation

@chihsuan

@chihsuan chihsuan commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

An earlier revision of this PR made ozone admin om quota repair version-aware, so that a key retaining more than one keyLocationVersions group was recounted per version instead of collapsing to the latest dataSize.

Per review on the Jira, no write path exercises bucket versioning today, and object versioning (HDDS-15728) keeps each object version in its own OmKeyInfo rather than adding groups here. The recount would therefore never run.

This revision drops the QuotaRepairTask change and records the invariant on the field instead, so the next reader does not have to re-derive it:

/**
 * Block locations of the key, one group per key version. No write path produces more than one group today, so a
 * key holds a single version and {@code dataSize} covers all of its blocks. Object versioning (HDDS-15728) keeps
 * each object version in its own OmKeyInfo rather than adding groups here.
 */
private List<OmKeyLocationInfoGroup> keyLocationVersions;

What is the link to the Apache JIRA?

https://issues.apache.org/jira/browse/HDDS-16127

How was this patch tested?

Javadoc only, no behavior change.

mvn -pl :ozone-common compile -DskipShade -DskipRecon -DskipDocs
./hadoop-ozone/dev-support/checks/checkstyle.sh

Generated-by: Claude Code (Opus 5)

Copilot AI lite review requested due to automatic review settings August 13, 2026 14:40
@chihsuan
chihsuan marked this pull request as ready for review August 13, 2026 16:50
@chihsuan chihsuan changed the title HDDS-16127. Fix quota repair usedBytes for versioned buckets HDDS-16127. Document that OmKeyInfo holds a single key version Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant