[flink] support rowId push down for RowTrackingTable #6605
+392
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Nov 16, 2025
| if (ROW_ID.name().equals(predicate.fieldName())) { | ||
| LeafFunction function = predicate.function(); | ||
| // _ROW_ID is always not null, so we can push down IsNull as an empty set. | ||
| if (function instanceof Equal || function instanceof In || function instanceof IsNull) { |
Contributor
There was a problem hiding this comment.
Remove IS_NULL? Is null optimization is for all non-null columns, not just for row id.
Author
There was a problem hiding this comment.
@JingsongLi Thanks for your review! I'm not very familiar about it, sorry for that. I've removed IS_NULL condition and added some ITCases. PTAL if you have some time!
added 2 commits
November 17, 2025 10:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is about to support rowid pushdown for flink, following #6483
Linked issue: None
Tests
Please see the test cases in org.apache.paimon.flink.source.FlinkTableSourceTest
API and Format
This PR does not change any user API
Documentation