-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PDFStreamEngine.java #27
base: trunk
Are you sure you want to change the base?
Conversation
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749569 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749570 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749740 13f79535-47bb-0310-9956-ffa450edef68
…er from twelvemonkeys; add check for orientation git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749936 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749937 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749960 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749965 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749967 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749973 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749974 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749976 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749983 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749985 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749989 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749994 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749995 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1749998 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1750006 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1750009 13f79535-47bb-0310-9956-ffa450edef68
…fined git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1750121 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1750130 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1750132 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1750139 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1750159 13f79535-47bb-0310-9956-ffa450edef68
…SStream git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1750362 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1750366 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1750368 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1750370 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1750372 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1750379 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1760246 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1760398 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1760401 13f79535-47bb-0310-9956-ffa450edef68
…gs in an encoding git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1760407 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1760420 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1760481 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1760577 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1760747 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1760959 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1760960 13f79535-47bb-0310-9956-ffa450edef68
…d, as suggested by Lorenz Pahl git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1760963 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1760966 13f79535-47bb-0310-9956-ffa450edef68
… Simon Gaeremynck git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1761055 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1761059 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1761238 13f79535-47bb-0310-9956-ffa450edef68
…suggested by Simon Steiner git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1761253 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1761320 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1761466 13f79535-47bb-0310-9956-ffa450edef68
… fonts git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1761485 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1761489 13f79535-47bb-0310-9956-ffa450edef68
There's no need to allocate new ArrayList in `processStreamOperators`. In my test case of a `4.2M` pdf, text extraction reduce from 16 seconds to 14 seconds.
This is a read only mirror. Please close this and open an issue in JIRA. |
Of course every speed increase is welcome, but this change is one to be discussed with "the rest of the gang" - what is if one of the |
@THausherr What do you mean by |
Any progress on this? The users of the passed array must make a copy of the arguments array. |
No progress, this is a read only mirror. I told to create an issue in JIRA. I won't create it myself because I'm not persuaded by this. If "The users of the passed array must make a copy of the arguments array." then where would be the speed gain? |
I should have written: The users of the passed array, which have to keep a list of the arguments, must make a copy of the arguments array. However I agree, this kind of optimalization must be investigated further, so that there is no unexpected side-effects. I've created #38 which investigates whether the ArrayList is in use after the call to processor. First impression is that this is not the case, and that the optimalization is possible. |
No need to allocate a new ArrayList here, reduce text extraction time from 16 seconds to 14 seconds on a 4.2M pdf.