Upgrade Avro and ORC to the latest compatible version #14148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14148 +/- ##
============================================
+ Coverage 61.75% 64.09% +2.33%
- Complexity 207 1538 +1331
============================================
Files 2436 2601 +165
Lines 133233 143501 +10268
Branches 20636 21978 +1342
============================================
+ Hits 82274 91970 +9696
+ Misses 44911 44752 -159
- Partials 6048 6779 +731
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
klsince
reviewed
Oct 2, 2024
| @@ -136,9 +136,9 @@ | |||
| <shade.prefix>org.apache.pinot.shaded</shade.prefix> | |||
| <shade.phase.prop>none</shade.phase.prop> | |||
|
|
|||
| <avro.version>1.11.3</avro.version> | |||
| <avro.version>1.11.4</avro.version> | |||
There was a problem hiding this comment.
would the dependabot bump the version up again?
There was a problem hiding this comment.
Not sure, but we can tell it to not bump it up when it files the new PR
klsince
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Avro to
1.11.4and ORC to1.9.4We cannot pick the latest versions of them for compatibility reason:
1.12.0has API change and bug, see Bump avro.version from 1.11.3 to 1.12.0 #137642.*.*drops the support of Java 11