Add PolarisObjectMapper #2164
Add PolarisObjectMapper #2164
Conversation
| @@ -187,8 +108,4 @@ public int getAttemptCount() { | |||
| return null; | |||
There was a problem hiding this comment.
if you look above this line, json errors around task state dont get reported to PolarisDiagnostics but are simply logged
| import org.apache.polaris.core.entity.PolarisBaseEntity; | ||
| import org.apache.polaris.core.entity.PolarisTaskConstants; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** A mapper to serialize/deserialize polaris objects. */ | ||
| public class PolarisObjectMapperUtil { | ||
| public final class PolarisObjectMapperUtil { |
There was a problem hiding this comment.
if we go forward with this PR we might want to rename this class as it now only deals with task (execution) state?
There was a problem hiding this comment.
Either way works for me :)
| @@ -41,16 +40,16 @@ public static TaskEntity of(PolarisBaseEntity polarisEntity) { | |||
|
|
|||
| public <T> T readData(Class<T> klass) { | |||
| PolarisCallContext polarisCallContext = CallContext.getCurrentContext().getPolarisCallContext(); | |||
There was a problem hiding this comment.
if PolarisObjectMapperUtil methods did not require the PolarisDiagnostics for reporting json-related errors, then this usage of CallContext.getCurrentContext() could go away (also below in this file).
There was a problem hiding this comment.
found this gem a well:
not yet, i will probably make an alternative PR where i remove update: alternative PR (which is better imo) now available #2176 |
|
closing as the alternative PR got merged |
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
all static methods that took a
PolarisCallContextas first parameter can be moved to the new class.if we did not need to log json-related exceptions to
PolarisDiagnostics(which we dont do in other places) then we could keep everything as static util methods.