Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Avoid IllegalStateException when marker_type field is not set in publishing #24087

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Mar 17, 2025

Motivation

As described in #24085, the changes in #23697 broke compatibility with existing protocol adapters.

Modifications

Avoid the IllegalStateException mentioned in #24085. This PR doesn't guarantee that there is compatibility, it simply addresses a single issue introduced by #23697 .

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.18%. Comparing base (bbc6224) to head (3260de2).
Report is 975 commits behind head on master.

Files with missing lines Patch % Lines
...roker/service/persistent/MessageDeduplication.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24087      +/-   ##
============================================
+ Coverage     73.57%   74.18%   +0.61%     
+ Complexity    32624    32059     -565     
============================================
  Files          1877     1863      -14     
  Lines        139502   144313    +4811     
  Branches      15299    16457    +1158     
============================================
+ Hits         102638   107065    +4427     
+ Misses        28908    28793     -115     
- Partials       7956     8455     +499     
Flag Coverage Δ
inttests 26.63% <0.00%> (+2.05%) ⬆️
systests 23.12% <0.00%> (-1.21%) ⬇️
unittests 73.69% <0.00%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roker/service/persistent/MessageDeduplication.java 76.02% <0.00%> (-4.90%) ⬇️

... and 1065 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit 3e6f7de into apache:master Mar 17, 2025
54 checks passed
lhotari added a commit that referenced this pull request Mar 20, 2025
…ot set in publishing (#24087)

(cherry picked from commit 3e6f7de)
lhotari added a commit that referenced this pull request Mar 20, 2025
…ot set in publishing (#24087)

(cherry picked from commit 3e6f7de)
lhotari added a commit that referenced this pull request Mar 20, 2025
…ot set in publishing (#24087)

(cherry picked from commit 3e6f7de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants