[fix][client] Avoid closing reused ServiceUrlProvider in another PulsarClientImpl instance#25947
Merged
Merged
Conversation
void-ptr974
approved these changes
Jun 6, 2026
void-ptr974
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The fix correctly ties ServiceUrlProvider.close() to successful initialization by the current client, and the added regression test covers the reused-provider failure path.
merlimat
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When the same
ServiceUrlProviderinstance is reused to build a secondPulsarClientImpl, the provider rejects the second initialization because each provider instance is tied to one client lifecycle.The second client constructor currently enters the failure cleanup path and calls
shutdown(), which closesconf.getServiceUrlProvider()unconditionally. This can close a provider that is still owned by the first live client.Modifications
PulsarClientImplsuccessfully initialized itsServiceUrlProvider.shutdown()only when this client successfully initialized it.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes