[fix][test] Fix flaky test ReplicatorTest.testResumptionAfterBacklogRelaxed#25950
Merged
merlimat merged 2 commits intoJun 8, 2026
Merged
Conversation
This was referenced Jun 6, 2026
merlimat
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ReplicatorTest.testResumptionAfterBacklogRelaxedcan time out after the remote backlog quota is relaxed. The test previously set the namespace backlog quota to1byte. That reliably forces the remote topic over quota, but it also leaves too little room for the pending replicated message after the existing backlog is drained. As a result, the replicator producer can keep being rejected withTopicBacklogQuotaExceededExceptionand wait for another reconnect backoff window, causing a false test failure.Fixes #25951.
Modifications
startProducer()call after the quota is relaxed, then wait until the replication backlog is cleared before consuming the final message.Verifying this change
./gradlew :pulsar-broker:test --tests org.apache.pulsar.broker.service.ReplicatorTest.testResumptionAfterBacklogRelaxed./gradlew :pulsar-broker:test --tests org.apache.pulsar.broker.service.ReplicatorTest.testResumptionAfterBacklogRelaxed --rerun-tasks