[improve][broker] Optimize SegmentedLongArray with heap-backed long[][]#26183
Open
nodece wants to merge 1 commit into
Open
[improve][broker] Optimize SegmentedLongArray with heap-backed long[][]#26183nodece wants to merge 1 commit into
nodece wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SegmentedLongArraypreviously used NettyByteBufas its backing store. EveryreadLong/writeLongoperation went throughByteBuf.getLong()/setLong(), adding extra indirection on the hot path ofTripleLongPriorityQueueheap operations(siftUp/siftDown).PR #26010 identified
SegmentedLongArrayas the remaining bottleneck after optimizing the heap algorithms, and suggested replacing the backing storage with primitive arrays.This PR replaces the
ByteBufbacking store with segmented heap-backedlong[][]arrays while preserving the segmented architecture required to support capacities beyondInteger.MAX_VALUEelements (PR #16490).Modifications
SegmentedLongArrayByteBufbacking store with segmented heap-backedlong[][]arrays.Benchmark Results
JMH benchmarks from
TripleLongPriorityQueueBenchmark(2 forks, 3 warmup iterations, 5 measurement iterations, JDK 21.0.5).Before (ByteBuf)
After (heap-backed
long[][])Comparison (Size = 2,000,000)