Conversation
…ing NaN With -a 1 the only send is the warm-up sample, elapsed stays 0 and the RT is computed as 0/0 = NaN; in tlog mode new BigDecimal(NaN) then throws NumberFormatException on the very first round, aborting the monitoring command. Reject the amount up front with a clear usage message since a single message cannot produce a measured RT.
RockteMQ-AI
approved these changes
Sep 11, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Good defensive fix — rejecting amount < 2 up front prevents the NaN/NumberFormatException that would otherwise abort the monitoring command. Clear error message explains why.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mqadmin clusterSendMsgRT -a 1cannot measure anything: the only send is the warm-up sample, elapsed stays 0, and the RT is computed as 0/0 =NaN. In tlog modenew BigDecimal(NaN)then throwsNumberFormatExceptionon the very first round, aborting the whole monitoring command.Modifications
Reject an amount below two up front with a clear usage message, since at least two messages are required for a measured RT.
Verification
Fail-before (new test, run against the unpatched code):
Pass-after: