Conversation
…Metadata exportMetadata summed retryQueueNums of the same subscription group over every master of the cluster the way topic queue numbers are totaled, so a group exported from an N-broker cluster came out with N times its real retryQueueNums. Subscription group config is cluster-wide: keep the first seen config instead of summing.
RockteMQ-AI
approved these changes
Sep 11, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Correct fix — subscription group config is cluster-wide and should not be accumulated across brokers. The putIfAbsent approach is clean and the test with two broker mockers validates the fix.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mqadmin exportMetadatasummedretryQueueNumsof the same subscription group over every master of the cluster, the way topic queue numbers are totaled. But a subscription group config is cluster-wide: a group exported from an N-broker cluster came out with N times its realretryQueueNums, and re-importing that metadata inflated every group's retry queues.Modifications
Keep the first seen config per group instead of summing, matching the cluster-wide semantics of subscription group config.
Verification
Fail-before (new test, run against the unpatched code):
Pass-after: