Conversation
…erves a failure detectByOneRound only flipped FaultItem.reachableFlag from false to true. Once a broker had been marked reachable, a failing service detector was ignored, so MQFaultStrategy's reachableFilter kept selecting a broker that had gone down until a real send happened to fail against it. Reset the flag symmetrically when the detector reports the broker unreachable.
RockteMQ-AI
approved these changes
Sep 11, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Fix the latency fault detector to clear the reachableFlag when a broker becomes unreachable. Previously, the flag was only set to true on recovery but never cleared on failure, causing stale reachability state.
LGTM — important fix for client-side load balancing correctness.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
LatencyFaultToleranceImpl.detectByOneRoundonly flippedFaultItem.reachableFlagfrom false to true. Once a broker had been marked reachable, a failing service detector was ignored, soMQFaultStrategy's reachable filter kept selecting a broker that had gone down until a real send happened to fail against it.Modifications
Reset the flag symmetrically when the detector reports the broker unreachable, so the next broker-selection round sees the failure.
Verification
Fail-before (new test, run against the unpatched code):
Pass-after: