Conversation
handleRpcMode validated the -c cluster name but then walked the whole brokerAddrTable, so the export request was sent to masters of every cluster, and brokers without a master resolved to a null address that silently routed the request through the name server channel. Iterate the brokers of the requested cluster and skip master-less brokers.
RockteMQ-AI
approved these changes
Sep 11, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Fix rocksDBConfigToJson in RPC mode to scope the operation to the requested cluster instead of iterating over all brokers. Also adds null guards for missing broker data and master addresses.
LGTM — correct scoping fix with comprehensive test (108 lines).
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
handleRpcModeofmqadmin rocksDBConfigToJsonvalidated the-ccluster name but then walked the wholebrokerAddrTable, so the export request was sent to the masters of every cluster instead of only the requested one. Brokers without a master resolved to a null address, whichdefaultMQAdminExtImplsilently routed through the name server channel.Modifications
Iterate the brokers of the requested cluster and skip master-less brokers.
Verification
Fail-before (new test, run against the unpatched code):
Pass-after: