Skip to content

[ISSUE #9728] fix: Broker startup failed when the consumequeue last mappfile was empty #9729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ISSUE #9728] fix: Broker startup failed when the consumequeue last mappfile was empty #9729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,18 +565,24 @@ public void correctMinOffset(long minCommitLogOffset) {
SelectMappedBufferResult lastRecord = null;
try {
int maxReadablePosition = lastMappedFile.getReadPosition();
lastRecord = lastMappedFile.selectMappedBuffer(maxReadablePosition - ConsumeQueue.CQ_STORE_UNIT_SIZE,
ConsumeQueue.CQ_STORE_UNIT_SIZE);
if (null != lastRecord) {
ByteBuffer buffer = lastRecord.getByteBuffer();
long commitLogOffset = buffer.getLong();
if (commitLogOffset < minCommitLogOffset) {
// Keep the largest known consume offset, even if this consume-queue contains no valid entries at
// all. Let minLogicOffset point to a future slot.
this.minLogicOffset = lastMappedFile.getFileFromOffset() + maxReadablePosition;
log.info("ConsumeQueue[topic={}, queue-id={}] contains no valid entries. Min-offset is assigned as: {}.",
topic, queueId, getMinOffsetInQueue());
return;
/*
if maxReadablePosition is less than ConsumeQueue.CQ_STORE_UNIT_SIZE,
it means the last file is empty and we need skip it otherwise selectMappedBuffer will throw IllegalArgumentException
*/
if (maxReadablePosition >= ConsumeQueue.CQ_STORE_UNIT_SIZE) {
lastRecord = lastMappedFile.selectMappedBuffer(maxReadablePosition - ConsumeQueue.CQ_STORE_UNIT_SIZE,
ConsumeQueue.CQ_STORE_UNIT_SIZE);
if (null != lastRecord) {
ByteBuffer buffer = lastRecord.getByteBuffer();
long commitLogOffset = buffer.getLong();
if (commitLogOffset < minCommitLogOffset) {
// Keep the largest known consume offset, even if this consume-queue contains no valid entries at
// all. Let minLogicOffset point to a future slot.
this.minLogicOffset = lastMappedFile.getFileFromOffset() + maxReadablePosition;
log.info("ConsumeQueue[topic={}, queue-id={}] contains no valid entries. Min-offset is assigned as: {}.",
topic, queueId, getMinOffsetInQueue());
return;
}
}
}
} finally {
Expand Down
Loading