bug: Support read_parquet glob file paths#34
Merged
jiayuasu merged 3 commits intoapache:mainfrom Sep 6, 2025
Merged
Conversation
paleolimbot
approved these changes
Sep 6, 2025
Member
paleolimbot
left a comment
There was a problem hiding this comment.
Remind me that I owe you cookies or chocolate cake someday for debugging this one.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one was pretty annoying to debug. Here's what was going on. We were calling
.to_urls()in twice: once ingeoparquet_listing_tableand once in here incontext.rs's read_parquet:sedona-db/rust/sedona/src/context.rs
Lines 229 to 235 in 5d3cfba
The second call was causing the
ListingTableUrl's glob attribute to being removed. I fixed this my removing one of the calls.Note: globbing with the
*operations still does NOT work on AWS s3 paths. That would need an additional fix / feature. It looks like Datafusion doesn't support globbing s3 paths yet either: It looks like DataFusion doesn't support globbing s3 paths yet either: apache/datafusion#16303