Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR splits the existing ST_SetSRID function to better align with database standards by creating two separate functions: ST_SetSRID which now accepts only integer SRID codes, and a new ST_SetCRS function which accepts string-based CRS definitions including EPSG codes and proj JSON.
- Refactored
ST_SetSRIDto accept only numeric SRID inputs for standards compliance - Added new
ST_SetCRSfunction that accepts string-based CRS identifiers - Extracted common logic into a shared
determine_return_typefunction
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rust/sedona-functions/src/st_setsrid.rs | Implements the function split with new ST_SetCRS struct, refactored validation logic, and comprehensive test coverage |
| rust/sedona-functions/src/register.rs | Registers the new st_set_crs_udf function in the function set and exports it in the stubs module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
ST_SetSRIDis out of line with other databases as it expects and accepts a string to allow for CRS codes and proj json. This change splits it intoST_SetSrid(which complies with standard expectations for that function) and the newST_SetCRSwhich allows our users to provide more interesting and complex CRS definitions.Issue: #29
Testing
Added unit tests, updated integration tests and ran tests with
cargo run. benchmark tests will be provided in another PR.Example
Examples correctly identifying setting the CRS:
Examples not accepting the other's arguments: