chore(ci): Move pyo3 extension module feature to Python args

[paleolimbot]

The pyo3 feature extension-module enables the actual Python extension, which causes problems for some cargo commands of the parent repo (e.g., cargo build --all). I had added this so that we could add the s2geography feature optionally for MacOS and Linux builds and they failed without it; however, that can be specified elsewhere.

[kylebarron]

https://pyo3.rs/v0.26.0/faq#i-cant-run-cargo-test-or-i-cant-build-in-a-cargo-workspace-im-having-linker-issues-like-symbol-not-found-or-undefined-reference-to-_pyexc_systemerror

[paleolimbot]

Thanks! That was definitely the issue (and I think that the pyprojects.toml value was overridden when I passed --features in the wheel build 😬 )

[Kontinuation]

Can we add a plain cargo build to our GitHub Workflow to catch this issue?

diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 1c57218..1c6bd19 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -49,7 +49,7 @@ jobs:
   rust:
     strategy:
       matrix:
-        name: ["clippy", "docs", "test"]
+        name: ["clippy", "build", "docs", "test"]
 
     name: "${{ matrix.name }}"
     runs-on: ubuntu-latest
@@ -117,6 +117,11 @@ jobs:
         run: |
           cargo clippy --workspace --all-targets --all-features -- -Dwarnings
 
+      - name: Build
+        if: matrix.name == 'build'
+        run: |
+          cargo build --workspace --all-targets --all-features
+
       - name: Test
         if: matrix.name == 'test'
         run: |

[paleolimbot]

Sure, in parallel maybe? I don't use cargo build for anything...is it useful? (cargo clippy and cargo test have always worked for me).

[Kontinuation]

Sure, in parallel maybe? I don't use cargo build for anything...is it useful? (cargo clippy and cargo test have always worked for me).

I use cargo build to build everything including sedona-cli. I think keeping the project building cleanly using the most commonly used command for building most Rust project is a good idea. Unless using cargo build is generally a bad practice for building any Rust projects.