fix(rust/sedona): Strip schema metadata when input uses RecordBatchReaderProvider#517
Merged
paleolimbot merged 7 commits intoapache:mainfrom Jan 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a schema metadata issue when using RecordBatchReaderProvider with foreign record batch readers (from Pandas or R). The solution strips schema metadata on input to work around DataFusion's schema propagation issues that cause optimizer rule failures.
Changes:
- Added a helper function to strip schema metadata from SchemaRef objects
- Updated RecordBatchReaderProvider constructor to strip metadata from input schemas
- Added a regression test using GeoPandas data to verify the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rust/sedona/src/record_batch_reader_provider.rs | Implements schema metadata stripping logic and updates the constructor to use it |
| python/sedonadb/tests/test_sjoin.py | Adds regression test for spatial joins with Pandas metadata |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foreign record batch readers/arrow array streams often contain schema metadata attached by Pandas or R, and sometimes that metadata can interfere with the ability of DataFusion internals to propagate a schema in such a way that the metadata remains unchanged (and thus fails assertions for optimizer rules recreating an identical schema).
The true fix is somewhere in DataFusion; however, as a workaround we can strip schema metadata on input since we aren't using it anyway.
Closes #477