Skip to content

chore(rust/sedona-geoparquet): Fix clippy errors #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kontinuation merged 2 commits into from
Jan 23, 2026
Merged

chore(rust/sedona-geoparquet): Fix clippy errors #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b8b1a8
fix clippy error
paleolimbot Jan 22, 2026
9c83ed8
fix one more
paleolimbot Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions rust/sedona-geoparquet/src/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,11 @@ impl FileFormat for GeoParquetFormat {
for metadata in &metadatas {
if let Some(kv) = metadata.file_metadata().key_value_metadata() {
for item in kv {
if item.key == "geo" && item.value.is_some() {
let this_geoparquet_metadata =
GeoParquetMetadata::try_new(item.value.as_ref().unwrap())?;
if item.key != "geo" {
continue;
}
if let Some(value) = &item.value {
let this_geoparquet_metadata = GeoParquetMetadata::try_new(value)?;

match geoparquet_metadata.as_mut() {
Some(existing) => {
Expand Down
8 changes: 6 additions & 2 deletions rust/sedona-geoparquet/src/metadata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,8 +385,12 @@ impl GeoParquetMetadata {
pub fn try_from_parquet_metadata(metadata: &ParquetMetaData) -> Result<Option<Self>> {
if let Some(kv) = metadata.file_metadata().key_value_metadata() {
for item in kv {
if item.key == "geo" && item.value.is_some() {
return Ok(Some(Self::try_new(item.value.as_ref().unwrap())?));
if item.key != "geo" {
continue;
}

if let Some(value) = &item.value {
return Ok(Some(Self::try_new(value)?));
}
}
}
Expand Down