feat(rust/sedona-functions): Add item SRID support to geometry constructors#574
Open
paleolimbot wants to merge 5 commits intoapache:mainfrom
Open
feat(rust/sedona-functions): Add item SRID support to geometry constructors#574paleolimbot wants to merge 5 commits intoapache:mainfrom
paleolimbot wants to merge 5 commits intoapache:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for item-level SRID (Spatial Reference System Identifier) to geometry constructor functions in the Rust implementation. The changes enable passing CRS information as a column reference instead of a scalar value, resulting in per-item CRS output.
Changes:
- Modified
ST_GeomFromWKBto accept an optional SRID argument - Updated
SRIDifiedKernelto handle both scalar and column CRS inputs - Added test coverage for array CRS functionality across ST_Point, ST_GeomFromWKT, and ST_GeomFromWKB
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rust/sedona-functions/src/st_setsrid.rs | Enhanced SRIDifiedKernel to support column-level CRS arguments and implement item CRS output |
| rust/sedona-functions/src/st_point.rs | Added test case for ST_Point with array CRS input |
| rust/sedona-functions/src/st_geomfromwkt.rs | Added test case for ST_GeomFromWKT with array CRS input |
| rust/sedona-functions/src/st_geomfromwkb.rs | Integrated SRIDifiedKernel and added test case for array CRS input |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
ST_GeomFromWKBCloses #126.