Skip to content

refactor(rust/sedona-spatial-join): Unify execute and execute_knn, move end-to-end tests in exec.rs to tests directory#593

Merged
Kontinuation merged 2 commits intoapache:mainfrom
Kontinuation:unify-execute-and-execute-knn
Feb 11, 2026
Merged

refactor(rust/sedona-spatial-join): Unify execute and execute_knn, move end-to-end tests in exec.rs to tests directory#593
Kontinuation merged 2 commits intoapache:mainfrom
Kontinuation:unify-execute-and-execute-knn

Conversation

@Kontinuation
Copy link
Member

@Kontinuation Kontinuation commented Feb 10, 2026

Summary

  • relocate spatial join integration tests from exec.rs into rust/sedona-spatial-join/tests/
  • keep test helpers and data builders intact while switching to public crate imports
  • preserve existing behavior while enabling integration-style execution

@Kontinuation Kontinuation changed the title test(rust/sedona-spatial-join): move integration tests refactor(rust/sedona-spatial-join): Unify execute and execute_knn, move end-to-end tests in exec.rs to tests directory Feb 10, 2026
@Kontinuation Kontinuation requested a review from Copilot February 10, 2026 15:36
@Kontinuation Kontinuation marked this pull request as ready for review February 10, 2026 15:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors SpatialJoinExec::execute to unify KNN and non-KNN execution paths, and relocates end-to-end spatial join tests from exec.rs into an integration test under tests/.

Changes:

  • Unifies execute logic for KNN and non-KNN predicates by selecting build/probe plans dynamically.
  • Removes the KNN-specific execute_knn implementation and shares component initialization + ordering logic.
  • Moves the large test suite out of src/exec.rs into rust/sedona-spatial-join/tests/spatial_join_integration.rs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
rust/sedona-spatial-join/src/exec.rs Unifies KNN + non-KNN execution logic and deletes inline unit tests from this module.
rust/sedona-spatial-join/tests/spatial_join_integration.rs Adds integration-style tests that exercise optimizer behavior and execution end-to-end.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Kontinuation Kontinuation force-pushed the unify-execute-and-execute-knn branch from 6310b0c to 0346bcc Compare February 10, 2026 16:14
@Kontinuation Kontinuation merged commit 51b2bc9 into apache:main Feb 11, 2026
16 checks passed
@paleolimbot paleolimbot added this to the 0.3.0 milestone Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants