refactor(rust/sedona-spatial-join): Unify execute and execute_knn, move end-to-end tests in exec.rs to tests directory#593
Merged
Kontinuation merged 2 commits intoapache:mainfrom Feb 11, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors SpatialJoinExec::execute to unify KNN and non-KNN execution paths, and relocates end-to-end spatial join tests from exec.rs into an integration test under tests/.
Changes:
- Unifies
executelogic for KNN and non-KNN predicates by selecting build/probe plans dynamically. - Removes the KNN-specific
execute_knnimplementation and shares component initialization + ordering logic. - Moves the large test suite out of
src/exec.rsintorust/sedona-spatial-join/tests/spatial_join_integration.rs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| rust/sedona-spatial-join/src/exec.rs | Unifies KNN + non-KNN execution logic and deletes inline unit tests from this module. |
| rust/sedona-spatial-join/tests/spatial_join_integration.rs | Adds integration-style tests that exercise optimizer behavior and execution end-to-end. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6310b0c to
0346bcc
Compare
paleolimbot
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec.rsintorust/sedona-spatial-join/tests/