refactor(rust/sedona-raster-functions): Split monolithic benchmark into per-function benchmark files#600
Closed
Kontinuation wants to merge 2 commits intoapache:mainfrom
Closed
refactor(rust/sedona-raster-functions): Split monolithic benchmark into per-function benchmark files#600Kontinuation wants to merge 2 commits intoapache:mainfrom
Kontinuation wants to merge 2 commits intoapache:mainfrom
Conversation
…ark files Split native-raster-functions.rs into separate benchmark files for each raster function group: rs_envelope, rs_geotransform, rs_rastercoordinate, rs_size, rs_srid, and rs_worldcoordinate. This makes it easier to run and analyze benchmarks for individual functions.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Rust raster-function benchmarks by splitting a single monolithic benchmark into multiple per-function benchmark targets and expanding coverage for some functions across multiple raster sizes.
Changes:
- Added new
criterionbenchmark files per function group (rs_envelope,rs_geotransform,rs_rastercoordinate,rs_size,rs_srid,rs_worldcoordinate). - Updated
Cargo.tomlbench targets to match the new benchmark filenames. - Added multi-size benchmark runs (64x64, 256x256, 1024x1024) for envelope and size (width/height).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rust/sedona-raster-functions/benches/rs_worldcoordinate.rs | Adds Criterion benchmarks for raster→world coordinate functions. |
| rust/sedona-raster-functions/benches/rs_srid.rs | Adds benchmarks for SRID/CRS accessors. |
| rust/sedona-raster-functions/benches/rs_size.rs | Adds multi-size benchmarks for width/height functions. |
| rust/sedona-raster-functions/benches/rs_rastercoordinate.rs | Removes unrelated benches and focuses file on world→raster coordinate benchmarks. |
| rust/sedona-raster-functions/benches/rs_geotransform.rs | Adds benchmarks for geotransform-derived properties (scale/rotation/skew/upper-left). |
| rust/sedona-raster-functions/benches/rs_envelope.rs | Adds multi-size benchmarks for envelope computation. |
| rust/sedona-raster-functions/Cargo.toml | Replaces the single native-raster-functions bench entry with per-file bench entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a802389 to
6a911e7
Compare
6a911e7 to
0d5156b
Compare
Member
Author
|
Most of the benchmarks in this module are just a few lines, splitting them to multiple files may not be a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benches/native-raster-functions.rsinto separate per-function benchmark files:rs_envelope,rs_geotransform,rs_rastercoordinate,rs_size,rs_srid, andrs_worldcoordinateCargo.toml[[bench]]entries to match the new file namesrs_envelope,rs_size(width/height)Rationale
We will add more raster functions later, having a monolithic benchmark file does not scale, so we'd better break it into several smaller files.