Skip to content

refactor(rust/sedona-raster-functions): Split monolithic benchmark into per-function benchmark files#600

Closed
Kontinuation wants to merge 2 commits intoapache:mainfrom
Kontinuation:pr7-benchmark-split
Closed

refactor(rust/sedona-raster-functions): Split monolithic benchmark into per-function benchmark files#600
Kontinuation wants to merge 2 commits intoapache:mainfrom
Kontinuation:pr7-benchmark-split

Conversation

@Kontinuation
Copy link
Member

@Kontinuation Kontinuation commented Feb 11, 2026

Summary

  • Split benches/native-raster-functions.rs into separate per-function benchmark files: rs_envelope, rs_geotransform, rs_rastercoordinate, rs_size, rs_srid, and rs_worldcoordinate
  • Updated Cargo.toml [[bench]] entries to match the new file names
  • Added multi-size benchmarks (64x64, 256x256, 1024x1024) for rs_envelope, rs_size (width/height)

Rationale

We will add more raster functions later, having a monolithic benchmark file does not scale, so we'd better break it into several smaller files.

…ark files

Split native-raster-functions.rs into separate benchmark files for each
raster function group: rs_envelope, rs_geotransform, rs_rastercoordinate,
rs_size, rs_srid, and rs_worldcoordinate. This makes it easier to run and
analyze benchmarks for individual functions.
@Kontinuation Kontinuation changed the title refactor(raster): split monolithic benchmark into per-function benchmark files refactor(rust/sedona-raster-functions): split monolithic benchmark into per-function benchmark files Feb 11, 2026
@Kontinuation Kontinuation requested a review from Copilot February 11, 2026 17:28
@Kontinuation Kontinuation changed the title refactor(rust/sedona-raster-functions): split monolithic benchmark into per-function benchmark files refactor(rust/sedona-raster-functions): Split monolithic benchmark into per-function benchmark files Feb 11, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Rust raster-function benchmarks by splitting a single monolithic benchmark into multiple per-function benchmark targets and expanding coverage for some functions across multiple raster sizes.

Changes:

  • Added new criterion benchmark files per function group (rs_envelope, rs_geotransform, rs_rastercoordinate, rs_size, rs_srid, rs_worldcoordinate).
  • Updated Cargo.toml bench targets to match the new benchmark filenames.
  • Added multi-size benchmark runs (64x64, 256x256, 1024x1024) for envelope and size (width/height).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
rust/sedona-raster-functions/benches/rs_worldcoordinate.rs Adds Criterion benchmarks for raster→world coordinate functions.
rust/sedona-raster-functions/benches/rs_srid.rs Adds benchmarks for SRID/CRS accessors.
rust/sedona-raster-functions/benches/rs_size.rs Adds multi-size benchmarks for width/height functions.
rust/sedona-raster-functions/benches/rs_rastercoordinate.rs Removes unrelated benches and focuses file on world→raster coordinate benchmarks.
rust/sedona-raster-functions/benches/rs_geotransform.rs Adds benchmarks for geotransform-derived properties (scale/rotation/skew/upper-left).
rust/sedona-raster-functions/benches/rs_envelope.rs Adds multi-size benchmarks for envelope computation.
rust/sedona-raster-functions/Cargo.toml Replaces the single native-raster-functions bench entry with per-file bench entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Kontinuation Kontinuation marked this pull request as ready for review February 11, 2026 17:36
@Kontinuation Kontinuation marked this pull request as draft February 11, 2026 17:50
@Kontinuation
Copy link
Member Author

Most of the benchmarks in this module are just a few lines, splitting them to multiple files may not be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants