Skip to content

feat(rust/sedona-geometry): Let CrsTransform handle M coordinate #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paleolimbot merged 1 commit into from
Feb 14, 2026
+354 −27
Merged

feat(rust/sedona-geometry): Let CrsTransform handle M coordinate #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion c/sedona-proj/src/transform.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ impl CrsTransform for ProjTransform {
Ok(())
}

fn transform_coord_3d(
fn transform_coord_xyz(
&self,
coord: &mut (f64, f64, f64),
_input_dims: Dimensions,
Expand Down
4 changes: 2 additions & 2 deletions rust/sedona-functions/src/st_affine_helpers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ pub(crate) enum DAffine {
}

impl CrsTransform for DAffine {
fn transform_coord_3d(
fn transform_coord_xyz(
&self,
coord: &mut (f64, f64, f64),
_input_dims: Dimensions,
Expand Down Expand Up @@ -632,7 +632,7 @@ mod tests {
let affine_3d =
DAffine::DAffine3(glam::DAffine3::from_scale(glam::DVec3::new(2.0, 3.0, 4.0)));
affine_3d
.transform_coord_3d(&mut coord_3d, Dimensions::Xyz)
.transform_coord_xyz(&mut coord_3d, Dimensions::Xyz)
.unwrap();
assert_eq!(coord_3d, (2.0, 6.0, 12.0));
}
Expand Down
2 changes: 1 addition & 1 deletion rust/sedona-functions/src/st_force_dim.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ impl CrsTransform for Force3DTransform {
"Unexpected call to transform_coord()".to_string(),
))
}
fn transform_coord_3d(
fn transform_coord_xyz(
&self,
coord: &mut (f64, f64, f64),
input_dims: Dimensions,
Expand Down
2 changes: 1 addition & 1 deletion rust/sedona-functions/src/st_translate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ impl CrsTransform for Translate {
Ok(())
}

fn transform_coord_3d(
fn transform_coord_xyz(
&self,
coord: &mut (f64, f64, f64),
_input_dims: Dimensions,
Expand Down
Loading