feat(rust/sedona-functions): Implement ST_Force3DM and ST_Force4D#620
Merged
paleolimbot merged 6 commits intoapache:mainfrom Feb 15, 2026
Merged
feat(rust/sedona-functions): Implement ST_Force3DM and ST_Force4D#620paleolimbot merged 6 commits intoapache:mainfrom
paleolimbot merged 6 commits intoapache:mainfrom
Conversation
Contributor
Author
|
The suspicious diff of |
yutannihilation
commented
Feb 15, 2026
Comment on lines
+461
to
+462
| Dimensions::Xym => (coord.x(), coord.y(), coord.nth_or_panic(2)), | ||
| Dimensions::Xyzm => (coord.x(), coord.y(), coord.nth_or_panic(3)), |
Contributor
Author
There was a problem hiding this comment.
I noticed this logic added in #619 was wrong. Fixed now.
paleolimbot
approved these changes
Feb 15, 2026
Member
paleolimbot
left a comment
paleolimbot
left a comment
There was a problem hiding this comment.
Thank you!
These functions are some of the least glorious but most essential functions...thank you for taking this on!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #554
This pull request implements
ST_Force3DMandST_Force4D.I tried to unify all
ST_Force*, but it seems it would make handling of optional args tricky (you can see the attempt at d9f46ed). So, this simply duplicate and tweak the code based on the existingST_Force2DandST_Force3D.