Merged
Conversation
paleolimbot
reviewed
Sep 13, 2025
Member
paleolimbot
left a comment
There was a problem hiding this comment.
Thank you!
(proj_sys is an optional dependency that isn't built in the Python bindings...instead we use the runtime linking feature...I think the suggestions will fix the build)
Collaborator
Author
|
Yeah, you are right, I was not thinking about whether the constant I referenced would be available without proj being installed. Good thing the build here caught that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, invalid inputs to proj via
ST_Transformare resulting in large log dumps to std out.For example, for a single row:
Since we are already capturing and sharing the error message, this change lowers the log level to none/0, but allows users to override it.
After this change, the excess error messages no longer appear and the user can jump straight to the useful error message. For example:
Tracking issue: #30