Migrate to edition 2024 and upgrade dependencies#65
Merged
wu-sheng merged 25 commits intoapache:masterfrom Apr 2, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 14.50% 13.59% -0.92%
==========================================
Files 20 21 +1
Lines 710 765 +55
==========================================
+ Hits 103 104 +1
- Misses 607 661 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project to Rust edition 2024 and upgrades various dependencies and CI/CD configurations to support newer systems and toolchains. Key changes include:
- Updating GitHub Actions workflows to run on ubuntu-24.04 and using the nightly-2025-03-24 Rust toolchain.
- Upgrading dependencies in Cargo.toml and related configuration files.
- Refining networking and build script setups, including changes in the e2e testing and build.rs modifications.
Reviewed Changes
Copilot reviewed 33 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/metrics/metricer.rs | Reordered task module items for consistency. |
| src/metrics/meter.rs | Adjusted import order; no functional changes. |
| src/management/instance.rs | Switched from Lazy to LazyLock for static variable initialization. |
| src/logging/record.rs | Reordered imports without affecting functionality. |
| rust-toolchain.toml | Upgraded toolchain channel from 1.65 to 1.85. |
| pyproject.toml | Added licensing and dependency information for the Python environment. |
| e2e/src/main.rs | Updated network addresses and refactored HTTP connection handling using TcpStream. |
| e2e/src/e2e_kafka.rs | Adjusted the expected broker IP address to match dependency updates. |
| e2e/data/expected_context.yaml | Updated peer addresses to align with the new network configuration. |
| e2e/Cargo.toml | Upgraded dependencies to newer versions supporting edition 2024 changes. |
| docker-compose.e2e.yml | Changed service networking from port mappings to host network mode. |
| docker-compose.dev.yml | Minor update removing the version specification. |
| build.rs | Introduced tonic_build::Config to support the vendored feature. |
| Cargo.toml | Updated package version, edition, rust-version, and numerous dependency versions. |
| .github/workflows/e2e.yml | Updated workflow to use docker compose commands and uv for Python dependency management. |
| .github/workflows/codecov.yaml | Replaced tarpaulin action with a manual cargo-tarpaulin installation step. |
| .github/workflows/ci.yaml | Updated CI workflow steps to the new Ubuntu version and Rust nightly toolchain. |
Files not reviewed (3)
- .python-version: Language not supported
- dist-material/LICENSE: Language not supported
- e2e/docker/Dockerfile: Language not supported
wu-sheng
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the CI/CD workflows and dependencies to ensure compatibility with newer versions of Ubuntu and Rust. Additionally, there are updates to the
Cargo.tomlfile and improvements to thebuild.rsscript.CI/CD Workflow Updates:
ubuntu-24.04instead ofubuntu-20.04in.github/workflows/ci.yaml,.github/workflows/codecov.yaml, and.github/workflows/e2e.yml. [1] [2] [3]nightly-2025-03-24and modified the commands to use this version in.github/workflows/ci.yaml. [1] [2] [3]actions-rs/tarpaulinwith a manual installation and execution of Tarpaulin in.github/workflows/codecov.yaml.uvfor Python dependency management and added a step to list Kafka topics in.github/workflows/e2e.yml.Dependency Updates:
Cargo.tomlto their latest versions, includingbase64,bytes,futures-core,futures-util,hostname,parking_lot,portable-atomic,prost,prost-derive,rdkafka,serde,systemstat,thiserror,tokio,tokio-stream,tonic,tracing, anduuid.2024and therust-versionto1.85inCargo.toml.Build Script Improvements:
tonic_build::Configto thebuild.rsscript to configure the Protobuf compiler when thevendoredfeature is enabled.Other Changes:
.python-versionfile.