Skip to content

SLING-12519 - Remove Double-Checked Locking in ScriptableBase.java #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scottyuancoc wants to merge 11 commits into
base: master
Choose a base branch
from
Open

SLING-12519 - Remove Double-Checked Locking in ScriptableBase.java #10

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
76a91e0
SLING-12519 - Remove Double-Checked Locking in ScriptableBase.java
scottyuancoc Dec 4, 2024
d19de13
Merge branch 'master' into bugfix/SLING-12519
scottyuancoc Jul 29, 2025
22ce146
SLING-12519 - Remove Double-Checked Locking in ScriptableBase.java
scottyuancoc Dec 4, 2024
6f3a811
SLING-12492 bump org.apache.sling.api to 2.25.4
enapps-enorman Dec 17, 2024
ffe719c
SLING-12730 Update to Parent 62
stefanseifert Mar 28, 2025
afa14fc
SLING-12730 apply spotless formatting
stefanseifert Mar 28, 2025
dc8df0f
SLING-12730 ignore spotless code reformatting commit in git blame
stefanseifert Mar 28, 2025
e50c5b1
Merge branch 'bugfix/SLING-12519' of github.com:scottyuancoc/sling-or…
scottyuancoc Jul 30, 2025
782cdd5
SLING-12730 ignore spotless code reformatting commit in git blame
stefanseifert Mar 28, 2025
c4fac55
Merge branch 'bugfix/SLING-12519' of github.com:scottyuancoc/sling-or…
scottyuancoc Jul 30, 2025
ed4e92d
SLING-12519 - Remove Double-Checked Locking in ScriptableBase.java
scottyuancoc Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/main/java/org/apache/sling/scripting/javascript/wrapper/ScriptableBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public abstract class ScriptableBase extends ScriptableObject {

public static final String JSFUNC_PREFIX = "jsFunction_";

/** Not thread-safe: designed for use in single-threaded environments only. */
protected Object getNative(String name, Scriptable start) {
final Object wrapped = getWrappedObject();

Expand All @@ -48,11 +49,7 @@ protected Object getNative(String name, Scriptable start) {
}

if (njo == null) {
synchronized (this) {
if (njo == null) {
njo = new NativeJavaObject(start, wrapped, getStaticType());
}
}
njo = new NativeJavaObject(start, wrapped, getStaticType());
}

return njo.get(name, start);
Expand Down