SLING-12516 - Migrate SlingContext to Rhino Context(ContextFactory) API#8
Open
scottyuancoc wants to merge 2 commits intoapache:masterfrom
Open
SLING-12516 - Migrate SlingContext to Rhino Context(ContextFactory) API#8scottyuancoc wants to merge 2 commits intoapache:masterfrom
scottyuancoc wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
scottyuancoc
commented
Dec 1, 2024
scottyuancoc
commented
- Replaced the deprecated Rhino Context() API with the updated Context(ContextFactory) API.
- Eliminated dependency on the Rhino global static singleton context factory.
scottyuancoc
force-pushed
the
feature/SLING-12516
branch
from
07315b7 to
c215143
Compare
rombert
requested changes
Dec 3, 2024
Contributor
rombert
left a comment
rombert
left a comment
There was a problem hiding this comment.
@scottyuancoc - I ran the Sling Starter ITs with your changes and I get two failures. Can you please check?
- build and install the code from this PR
- clone
https://github.com/apache/sling-org-apache-sling-starter/ - update
src/main/features/scripting.jsonto reference the SNAPSHOT version you just built - run
mvn clean installin the starter project
For me, this results in
[ERROR] Tests run: 573, Failures: 2, Errors: 0, Skipped: 1
|
* Replace the deprecated Rhino Context() API with the updated Context(ContextFactory) API. * Align the implementation with the Rhino global static context factory model. * Add test cases to ensure alignment with the Rhino global static context factory model.
scottyuancoc
force-pushed
the
feature/SLING-12516
branch
from
2cb3fa5 to
231737a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.