[SPARK-52356][PS] Enable divide-by-zero for boolean mod/rmod with ANSI enabled #51058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
changed the title
|
@ueshin would you please review, thanks! |
|
@ueshin @HyukjinKwon @zhengruifeng thanks! |
HyukjinKwon
reviewed
Jun 4, 2025
HyukjinKwon
approved these changes
Jun 5, 2025
ueshin
approved these changes
Jun 6, 2025
|
Thanks! merging to master. |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…I enabled ### What changes were proposed in this pull request? Enable divide-by-zero for boolean mod/rmod with ANSI enabled ### Why are the changes needed? Ensure pandas on Spark works well with ANSI mode on. Part of https://issues.apache.org/jira/browse/SPARK-52169. ### Does this PR introduce _any_ user-facing change? Yes, divide-by-zero is enabled when ANSI is on, as shown below: ``` >>> ps.set_option("compute.fail_on_ansi_mode", False) >>> pser = pd.Series([True, False]) >>> psser = ps.from_pandas(pser) >>> ps.set_option("compute.ansi_mode_support", True) >>> spark.conf.set("spark.sql.ansi.enabled", True) >>> 1 % psser 0 0.0 1 NaN dtype: float64 # Same as ANSI off >>> spark.conf.set("spark.sql.ansi.enabled", False) >>> 1 % psser 0 0.0 1 NaN dtype: float64 ``` ### How was this patch tested? Unit tests, and ```py (dev3.10) spark (divide_0_tests) % SPARK_ANSI_SQL_MODE=true ./python/run-tests --python-executables=python3.10 --testnames "pyspark.pandas.tests.data_type_ops.test_boolean_ops BooleanOpsTests.test_mod" Running PySpark tests. Output is in /Users/xinrong.meng/spark/python/unit-tests.log ... Finished test(python3.10): pyspark.pandas.tests.data_type_ops.test_boolean_ops BooleanOpsTests.test_mod (5s) Tests passed in 5 seconds (dev3.10) spark (divide_0_tests) % SPARK_ANSI_SQL_MODE=true ./python/run-tests --python-executables=python3.10 --testnames "pyspark.pandas.tests.data_type_ops.test_boolean_ops BooleanOpsTests.test_rmod" Running PySpark tests. Output is in /Users/xinrong.meng/spark/python/unit-tests.log ... Finished test(python3.10): pyspark.pandas.tests.data_type_ops.test_boolean_ops BooleanOpsTests.test_rmod (4s) Tests passed in 4 seconds ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#51058 from xinrong-meng/bool_mod. Authored-by: Xinrong Meng <[email protected]> Signed-off-by: Takuya Ueshin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable divide-by-zero for boolean mod/rmod with ANSI enabled
Why are the changes needed?
Ensure pandas on Spark works well with ANSI mode on.
Part of https://issues.apache.org/jira/browse/SPARK-52169.
Does this PR introduce any user-facing change?
Yes, divide-by-zero is enabled when ANSI is on, as shown below:
How was this patch tested?
Unit tests, and
Was this patch authored or co-authored using generative AI tooling?
No