[SPARK-52533] Support enabling only driver profiler #51223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code change LGTM, but SPARK-50811 has been delivered in 4.0.0, this should be qualified as a bugfix, please create a new JIRA ticket. |
wForget
changed the title
Thank you, added a new ticket SPARK-52533 |
wForget
force-pushed
the
SPARK-50811-followup
branch
from
9a6697c to
774e6f4
Compare
|
Gentle ping @parthchandra @dongjoon-hyun, could you please take a look? |
dongjoon-hyun
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
+1, LGTM. Thank you, @wForget , @pan3793 , @HyukjinKwon , @parthchandra .
Merged to master for Apache Spark 4.1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove profiler executor enabled check in SparkAsyncProfiler
Why are the changes needed?
There are already profiler enabled checks in ProfilerPlugin. We should remove the redundant check in SparkAsyncProfiler to support only driver profiler enabled.
spark/connector/profiler/src/main/scala/org/apache/spark/profiler/ProfilerPlugin.scala
Lines 48 to 49 in 8222670
spark/connector/profiler/src/main/scala/org/apache/spark/profiler/ProfilerPlugin.scala
Lines 78 to 79 in 8222670
Does this PR introduce any user-facing change?
No
How was this patch tested?
minor improve
Was this patch authored or co-authored using generative AI tooling?
No