[SPARK-52544][SQL] Allow configuring Json datasource string length limit through SQLConf #51235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan |
HyukjinKwon
changed the title
HyukjinKwon
reviewed
Jun 23, 2025
| buildConf("spark.sql.json.defaultMaxStringLength") | ||
| .doc("Global default maximum string length limit when reading JSON data. It will be " + | ||
| "overridden if a JSONOption maxStringLen is provided.") | ||
| .version("3.5.0") |
There was a problem hiding this comment.
This needs to be backported to 3.5 to fix a regression, how about 3.5.7?
cloud-fan
reviewed
Jun 23, 2025
| @@ -55,7 +55,7 @@ class JSONOptions( | |||
| private val maxStringLen: Int = parameters | |||
| .get("maxStringLen") | |||
| .map(_.toInt) | |||
| .getOrElse(StreamReadConstraints.DEFAULT_MAX_STRING_LEN) | |||
| .getOrElse(SQLConf.get.getConf(SQLConf.JSON_MAX_STRING_LENGTH)) | |||
There was a problem hiding this comment.
can we follow ParquetOptions and pass a SQLConf instance to construct JSONOptions?
cloud-fan
reviewed
Jun 23, 2025
|
|
||
| test("Test JSON data source maxStringLen option") { | ||
| // Create a JSON string that is way longer than DEFAULT_MAX_STRING_LEN. | ||
| val longStringSize = StreamReadConstraints.DEFAULT_MAX_STRING_LEN * 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In https://issues.apache.org/jira/browse/SPARK-43263, Spark upgraded Jackson to 2.15.0. This brought in a breaking change that set string max length to 20,000 which Json data source picked up. Before the upgrade, there was no limit. The limit could only be modified through Json option "maxStringLen".
This PR attempts to restore the old no limit behavior, by introducing a new JSON_MAX_STRING_LENGTH feature flag that sets the string length limit globally.
Why are the changes needed?
To restore the old string length limit behavior of Json connector, prior to the upgrade to Jackson 2.15.0.
Does this PR introduce any user-facing change?
Yes, added a new user configurable config for specifying max string length for Json connector.
How was this patch tested?
New unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.