-
Notifications
You must be signed in to change notification settings - Fork 28.9k
skip slowness test #52431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip slowness test #52431
Conversation
I conducted a sampling analysis on the data from all Python tests and found that the following 16 test cases have execution times exceeding 60 seconds (for the time being, let's assume 60 seconds as the threshold; should we consider choosing a larger threshold?). Should we temporarily disable them and then re-enable them after optimizing their execution times? What are your opinions on this? @zhengruifeng @dongjoon-hyun @HyukjinKwon
|
Thank you for collecting the result and shedding the light to us, @LuciferYang . BTW, |
Yes, the statistical unit here is a test case, rather than a test file or a test class. |
Thank you so much for spending your time on this. I really appreciate your passion, @LuciferYang . I rechecked the usage Today. It seems that we spent The root cause seems that Apache Spark repository has less commits in these days. On August, we had lots of commits. ![]() For now, let's keep the AS-IS status which means to increase the timeout-limit without skipping (until we need a serious action). We can skip the tests easily always if needed later, but recovering test coverage happens seldomly. WDYT? |
@dongjoon-hyun Ok ~ let me close this pr first. If there's a need later on, the statistical data from this pr can serve as a reference. |
Thanks @LuciferYang and @dongjoon-hyun for the investigation, the data is very useful. |
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?