Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 12, 2025

What changes were proposed in this pull request?

This PR aims to recover MacOS CIs by installing zstandard==0.25.0.

Why are the changes needed?

After SPARK-54194, zstandard Python package is required for Connect.

Currently, MacOS CIs are broken.

Traceback (most recent call last):
  File "/Users/runner/work/spark/spark/python/pyspark/sql/connect/utils.py", line 105, in require_minimum_zstandard_version
    import zstandard  # noqa
    ^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'zstandard'

Does this PR introduce any user-facing change?

No behavior change.

How was this patch tested?

Pass the CIs and manual review because MacOS CIs are triggered daily CIs only.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Could you review this PR, @yaooqinn ?

@yaooqinn
Copy link
Member

After SPARK-54193, zstandard Python package is required for Connect.

Wrong JIRA ticket? otherwise, LGTM

@dongjoon-hyun
Copy link
Member Author

Oh, thank you! I fixed it.

dongjoon-hyun added a commit that referenced this pull request Nov 13, 2025
### What changes were proposed in this pull request?

This PR aims to recover MacOS CIs by installing `zstandard==0.25.0`.

### Why are the changes needed?

After SPARK-54194, `zstandard` Python package is required for `Connect`.
- #52894

Currently, MacOS CIs are broken.
- https://github.com/apache/spark/actions/workflows/build_python_3.11_macos26.yml
- https://github.com/apache/spark/actions/workflows/build_python_3.11_macos.yml

```
Traceback (most recent call last):
  File "/Users/runner/work/spark/spark/python/pyspark/sql/connect/utils.py", line 105, in require_minimum_zstandard_version
    import zstandard  # noqa
    ^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'zstandard'
```

### Does this PR introduce _any_ user-facing change?

No behavior change.

### How was this patch tested?

Pass the CIs and manual review because MacOS CIs are triggered daily CIs only.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #53025 from dongjoon-hyun/SPARK-54326.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 5c16a73)
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Member Author

Merged to master/4.1.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-54326 branch November 13, 2025 02:41
@zhengruifeng
Copy link
Contributor

late LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants