[SPARK-54312][CORE] Avoid repeatedly scheduling tasks for SendHeartbeat/WorkDirClean in standalone worker #53054
+49
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up after registratiion
Contributor
Author
|
cc @Ngone51 @LuciferYang @dongjoon-hyun can you please take a look? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, worker will schedule tasks forwarding
SendHeartbeatandWorkDirCleanupwhilehandleRegisterResponse.While worker registration could happen multiple times in case of heartbeat timeout/disconnected from master, in these cases the tasks would be scheduled multiple times.
To fix the issue:
heartbeatTaskandworkDirCleanupTaskin worker to tell whether these tasks have been scheduledheartbeatTaskandworkDirCleanupTaskwill be initialized after the 1st registration, and then skipped scheduling these tasks in later registration.heartbeatTaskandworkDirCleanupTaskwhen worker stops.Why are the changes needed?
Fix the issue repeatedly scheduling SendHeartbeat/WorkDirClean tasks after worker registration.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT added
Was this patch authored or co-authored using generative AI tooling?
No