fix(mcp): expose table column formatting - #42658
Draft
aminghadersohi wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #42658 +/- ##
==========================================
- Coverage 65.44% 65.44% -0.01%
==========================================
Files 2810 2810
Lines 159366 159381 +15
Branches 36374 36379 +5
==========================================
+ Hits 104302 104308 +6
- Misses 53022 53031 +9
Partials 2042 2042
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Expose per-column table formatting in MCP chart configurations. Table configs can set
columnWidth,d3NumberFormat, andd3TimeFormat, keyed by result column label, and the generated schema documents concrete D3 format examples.Existing table
column_configvalues are preserved when an update omits the field, while explicit values are validated and serialized without silently dropping unknown settings.TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
BLAST RADIUS
Limited to MCP table chart configuration schemas and form-data mapping. It does not change authorization, database models, migrations, or non-MCP chart behavior.
RISK AND ROLLBACK
The main risk is accepting a formatting value that the frontend renders differently than expected. Validation constrains field names and primitive types, and rollback is a normal revert with no data migration.
REVIEW GUIDANCE
Start with
TableColumnConfiginschemas.py, then review the form-data mapping and preservation paths in the two update tools.EVAL EVIDENCE
The deterministic schema and round-trip paths are covered by 189 passing focused MCP unit tests. No model-based evaluation suite was available in this checkout.
COST AND LATENCY DELTA
No prompt, model, routing, or tool-call changes. The added local schema validation and dictionary serialization have negligible request cost and latency impact.
PROMPT / NON-DETERMINISM
No prompt or non-deterministic behavior changed.