fix(reports): anchor tiled budget clock at overall screenshot start

[eschutho]

SUMMARY

Follow-up to #42118, implementing @rebenitez1802's non-blocking review suggestion left at merge time (#42118 (comment) — "tiled budget clock resets instead of accounting for pre-capture time").

The tiled wait budget is derived from the running Celery task's own time limit, but elapsed time was measured from a clock started inside take_tiled_screenshot() — so page.goto (bounded 60s), the headstart sleep, element.wait_for, and dimension probing all ran before the clock started. The tile loop effectively got a fresh full budget on top of task time already spent. In the common case the 20%/300s cleanup margin absorbs the overhang (and a soft-limit overrun still surfaces as a clean SoftTimeLimitExceeded), but on hard-limit-only tasks the uncounted pre-capture time plus a full budget of tiled waits can still crest the hard limit — the SIGKILL #42118 exists to prevent.

The non-tiled readiness wait already avoids this: #42427 threads screenshot_started_at from the top of get_screenshot into _wait_for_charts_ready and subtracts already-elapsed time. This PR applies exactly the same pattern to the tiled call — the three coordinated changes from the review suggestion:

1. take_tiled_screenshot() accepts screenshot_started_at: float | None = None and anchors the budget clock on it (falls back to "now" when omitted, preserving the existing API for any other caller);
2. WebDriverPlaywright.get_screenshot() passes its existing screenshot_started_at into the tiled call;
3. both capture paths now share one clock.

TESTING INSTRUCTIONS

pytest -q tests/unit_tests/utils/   # 732 passed
ruff check / ruff format --check    # clean

New tests: with screenshot_started_at provided, 900s of pre-capture elapsed time reduces the first tile's capped wait to the true remaining budget (100s of a 1000s budget, not the full load_wait); with it omitted, the local-clock default behaves exactly as before. The existing tiled call-site assertion now pins the new argument being forwarded.

ADDITIONAL INFORMATION

• Has associated issue: follow-up to fix(reports): time-budget tiled screenshot to fail cleanly instead of hitting Celery kill #42118; pattern from fix(reports): make #42253 screenshot readiness production-safe #42427
• Required feature flags:
• Changes UI
• Includes DB Migration
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #32a320

Actionable Suggestions - 0

Review Details

• Files reviewed - 4 · Commit Range: 9536a28..9536a28

  • superset/utils/screenshot_utils.py
  • superset/utils/webdriver.py
  • tests/unit_tests/utils/test_screenshot_utils.py
  • tests/unit_tests/utils/webdriver_test.py
• Files skipped - 0
• Tools

  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.42%. Comparing base (6929d03) to head (9536a28).

Files with missing lines	Patch %	Lines
superset/utils/screenshot_utils.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #42661   +/-   ##
=======================================
  Coverage   65.42%   65.42%           
=======================================
  Files        2810     2810           
  Lines      159422   159422           
  Branches    36382    36382           
=======================================
  Hits       104309   104309           
  Misses      53070    53070           
  Partials     2043     2043           

Flag	Coverage Δ
hive	38.07% <0.00%> (ø)
mysql	57.79% <0.00%> (ø)
postgres	57.84% <0.00%> (ø)
presto	39.96% <0.00%> (ø)
python	59.22% <0.00%> (ø)
sqlite	57.46% <0.00%> (ø)
unit	100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[eschutho]

Folding this into #42624 rather than maintaining it standalone: #42624 restructures the exact code this PR patches (the tiled budget clock), and its report-path deadline already starts at task start — superseding this anchor for scheduled reports. The residual non-report case (thumbnails routed to tiling counting pre-capture time) is now implemented on #42624's branch with the same tests, credited to the original review suggestion on #42118. Branch stays for reference.