Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FUTURE][SYSTEMML-1572] Enable native BLAS on remote executors #481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

niketanpansare
Copy link
Contributor

@mboehm7 can you please review this PR ?

@bertholdreinwald

@mboehm7
Copy link
Contributor

mboehm7 commented May 3, 2017

I'll try to have a look next week. In the meantime, you might want to revisit the integration approach - the large number of files you had to modify is already an indicator that this is probably not a good approach.

It should be fairly simply: create a single static call which dispatches between matrix block (which should not call libnative at all) and libnative, initialize once, and call it for each matrix multiplication that potentially calls native BLAS - for example for compressed matrix blocks this is never required.

@niketanpansare
Copy link
Contributor Author

@mboehm7 This approach allows the matrix multiplication on remote executor to respect the configuration flag native.blas. Since the configuration is not sent to the executor, not sure how single static call will enable that. But, we can discuss this next week after you have had chance to look at it :)

@akchinSTC
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1435/

@bertholdreinwald
Copy link
Contributor

Not working as despite <native.blas>true</native.blas> in SystemML-config.xml, another env var disables it.

17/05/03 09:07:33 WARN utils.NativeHelper: Using internal Java BLAS as native BLAS support is disabled by the environment variable 'SYSTEMML_BLAS='.

@akchinSTC
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1438/

@j143 j143 changed the title [SYSTEMML-1572] Enable native BLAS on remote executors [FUTURE][SYSTEMML-1572] Enable native BLAS on remote executors Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Unplanned
Development

Successfully merging this pull request may close these issues.

4 participants