Add Java 25 build compatibility for TinkerPop 3.8 #3283
+43
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables building TinkerPop with Java 25 by: 1. Updating Groovy version to 4.0.30-SNAPSHOT which includes ASM 9.9 (required for Java 25 class file version 69 support) 2. Adding explicit annotationProcessorPaths to gremlin-groovy's maven-compiler-plugin configuration. This ensures the GremlinDsl annotation processor can load its dependencies (javapoet, gremlin-core) which is required due to stricter classloader isolation in Java 25. Build requirements: - Requires local installation of Groovy 4.0.30-SNAPSHOT with ASM 9.9 - Use -Denforcer.skip=true to bypass Java version check - Use -Dmaven.javadoc.skip=true due to Groovy source path issues
jrepp
force-pushed
the
jrepp/java-25-groovy-asm-compat
branch
from
b159185 to
b8734ac
Compare
- LambdaRestrictionStrategy: Use case-insensitive check for lambda class names (Java 25 changed lambda naming to $$Lambda/ instead of $$lambda$) - ImportGremlinPluginTest: Handle Math.TAU field added in Java 19
jrepp
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.8-dev #3283 +/- ##
==========================================
Coverage ? 77.31%
Complexity ? 15022
==========================================
Files ? 1159
Lines ? 71961
Branches ? 8031
==========================================
Hits ? 55639
Misses ? 13268
Partials ? 3054 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enables building TinkerPop with Java 25 by updating Groovy and fixing annotation processor configuration.
Changes
Build Configuration
pom.xml: Updatedgroovy.versionto4.0.30-SNAPSHOT(includes ASM 9.9 for Java 25 support)gremlin-groovy/pom.xml: Added explicitannotationProcessorPathsforGremlinDslProcessorTest Fixes
LambdaRestrictionStrategy.java: Use case-insensitive lambda detection (Java 25 changed class naming from$$Lambda$N/...to$$Lambda/0x...)ImportGremlinPluginTest.java: HandleMath.TAUfield added in Java 19Build Instructions
Prerequisites: Local Groovy 4.0.30-SNAPSHOT with ASM 9.9 - see apache/groovy#2346
Test Results
Note: hadoop-gremlin failures are pre-existing Hadoop + Java 25 incompatibility issues, not related to this PR.
Blocking Dependency
The linked Groovy PR updates ASM from 9.7 to 9.9, which is required to parse Java 25 class files (class file version 69). Without this ASM update, Groovy cannot compile or load classes built with Java 25, causing
IllegalArgumentExceptionerrors during bytecode analysis.Once that Groovy PR is released (likely as 4.0.25 or later), update the
groovy.versioninpom.xmlfrom4.0.30-SNAPSHOTto the actual release version.Notes for Maintainers
annotationProcessorPathschange is backward compatible and follows Maven best practices[11,18)will need updating for official Java 25 support