Fix minor noise projection in blockwise singlepass via final fixed-V LS refit#186
Draft
Lindsey-cyber wants to merge 1 commit into
Draft
Fix minor noise projection in blockwise singlepass via final fixed-V LS refit#186Lindsey-cyber wants to merge 1 commit into
Lindsey-cyber wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a consistency issue in
blockwise_decomposition_singlepass.After the final temporal basis
Vis computed (and optionally denoised), we now recompute the spatial basisUusing a least-squares fit on the original normalized block.This removes the extra spatial-projection path and ensures that the returned
Uis the optimal fit for the finalV.What Changed
Keep the existing pipeline for estimating the final temporal basis
V.Before returning, recompute
Uby solving:using a QR-based solve.
No change to behavior for empty or rank-0 edge cases.
Note: No algorithmic change to temporal basis estimation itself. By refitting
UwithVfixed,Uis now consistent with the actual basis used for reconstruction. Minor projection artifacts are removed.