Pmd blockwise rank storage (#178)#197
Open
u-ferah wants to merge 2 commits into
Open
Conversation
u-ferah
force-pushed
the
pmd_rank_storage
branch
from
c22f7bb to
03ef190
Compare
* Added optional property to store the per block rank count to PMDArray as PMDArray.block_ranks stored as a torch tensor. (Solves apasarkar#178) * Implemented counting and storing of block ranks to pmd_decomposition function. * Added variable to control spike detection minimum distance window (was previously hard set to 10)
u-ferah
force-pushed
the
pmd_rank_storage
branch
from
03ef190 to
444acdc
Compare
Contributor
Author
|
Removed filtering code (for further discussion in a separate issue). Also, fixed a bug where the block rank was not stored when the block's rank was 0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added optional property to store the per block rank count to PMDArray as PMDArray.block_ranks stored as a torch tensor. (Solves Storing blockwise PMD rank #178)
Implemented counting and storing of block ranks to pmd_decomposition function.
Added option to run bandpass filters on factorized movies (in V) or vectorized movie arrays similar to the high pass filter
Added variable to control spike detection minimum distance window (was previously hard set to 10)