Skip to content

fix: don't force pass seed to llm service and default alignment threshold to 0 #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: don't force pass seed to llm service and default alignment threshold to 0 #461

wants to merge 2 commits into from

Conversation

@percevalw
Copy link
Member

@percevalw percevalw commented Nov 17, 2025 •
edited
Loading

Description

  • Don't pass seed to openai API calls (only as extra body)
  • Default to alignment threshold = 0 (better recall) for LLM annotated markup alignment with the original text

Todo:

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 21, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
15.4% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@percevalw