Skip to content

omit children prop in UseOnSubmitProps type #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

omit children prop in UseOnSubmitProps type #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/create/CreateGuesser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ export const IntrospectedCreateGuesser = ({
mutationOptions,
transform,
redirectTo,
children: [],
});

const displayOverrideCode = useDisplayOverrideCode();
Expand Down
1 change: 0 additions & 1 deletion src/edit/EditGuesser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ export const IntrospectedEditGuesser = ({
mutationOptions,
transform,
redirectTo,
children: [],
});
useMercureSubscription(resource, id);

Expand Down
2 changes: 1 addition & 1 deletion src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,4 +520,4 @@ export type UseOnSubmitProps = Pick<
'schemaAnalyzer' | 'resource' | 'fields'
> &
Pick<CreateProps, 'mutationOptions' | 'transform'> &
PickRename<CreateProps, 'redirect', 'redirectTo'>;
PickRename<Omit<CreateProps, 'children'>, 'redirect', 'redirectTo'>;
1 change: 0 additions & 1 deletion src/useOnSubmit.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const onSubmitProps = {
fields: API_FIELDS_DATA,
resource: 'books',
schemaAnalyzer: schemaAnalyzer(),
children: [],
};

jest.mock('./getIdentifierValue.js');
Expand Down