fix: skip openapi webhooks when generating routes #7175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexndlm
commented
May 26, 2025
alexndlm
commented
| Q | A |
|---|---|
| Branch? | main |
| Tickets | |
| License | MIT |
| Doc PR |
|
I'm not sure I understand, shouldn't the webhook be available as a route? I'm not a huge fan of the responsibility here, the OpenApi specification should not define routes but it's the other way around. |
|
Webhooks should be visible only in the documentation. The application is responsible for sending them to consumers. Of course, if you have no plans somehow to integrate the sending of webhooks into the API platform. |
|
Indeed it's actually not a route, could you target 4.1 though as this is a bug fix? |
soyuka
changed the title
soyuka
changed the title
alexndlm
force-pushed
the
feature/remove-webhooks-from-routing
branch
from
2063025 to
ffaac64
Compare
alexndlm
force-pushed
the
feature/remove-webhooks-from-routing
branch
from
ffaac64 to
40f49cf
Compare
|
Done. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.