-
Notifications
You must be signed in to change notification settings - Fork 169
feat: Small copy improvements #2189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a9bb224
Better copy
jancurn 89b23fa
Better copy
jancurn d84064a
Fix width
jancurn a1bb717
Better copy
jancurn 8bbf7fc
Better copy
jancurn ad845ce
Better copy
jancurn 684db61
Better copy
jancurn aa82825
Better copy
jancurn d49b81e
Update src/pages/sdk/index.tsx
jancurn 48352f4
Better copy
jancurn 7a64c41
Merge remote-tracking branch 'origin/jan/fixes' into jan/fixes
jancurn bff62a6
Update src/pages/sdk/index.tsx
jancurn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't use
Learnhere since this is just the link to the full API ref, we don't teach there anything, and there is no narrative like for example in Academy's courses by @honzajavorekThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is the top line, imo it works there. Or what other word to put there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current "Learn how to use" copy suggests guides or tutorials, but this page is reference documentation (REST API + client libraries).
I'd swap it out for something more developer-focused:
It's developer-focused, outcome-oriented, and accurately cover both the REST API and client libraries covered on this page.
Other options if you prefer:
More general capability focus:
Most concise (closest to original):
I'd go with the "Integrate" version, but all three fix the main issue. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that sounds like some CTA in Console. Whenever we link to docs from Console or other places, we often call the link "Learn more". IMO "learn" is perfectly okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E.g. see https://docs.stripe.com/workflows or https://vercel.com/docs/integrations/create-integration/marketplace-api
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I understand the concern, and I appreciate you bringing those examples.
The key difference: those Stripe and Vercel examples link to content that has substantial how-to guides alongside the API reference.
This API landing page links to TWO different content types:
Even our own client library docs (docs.apify.com/api/client/js and /python) don't use "Learn" in their descriptions - they describe what the library is rather than what you'll learn. The main selling point across all these sections is the referential documentation, with some guided content as supporting material.
Using "Learn" sets an expectation for tutorial-style instruction, but users primarily come here to look up API endpoints, method signatures, and parameters. If you are not keen on CTA-coded
Integrateperhaps:would more accurately represent the reference-heavy nature of the content.
Happy to stick with
Learnif you prefer, but wanted to flag that the current structure is more reference-focused than those comparison examples.