Ep002 e #317
Closed
Ep002 e #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correct logic in plugin FR001, so that:
- if there is a single FaultRule, with no Condition,
it results in a warning "consider migrating to DefaultFaultRule".
- If there are multiple FaultRules, if any except the first or last,
depending on whether proxy or target, has no Condition, generate
an error.
- new FR003 generates a warning with single FaultRule and no Condition - FR001 generates errors with multiple FaultRules, and a rule other than the fallback lacks a Condition - refactor tests to align with this function - update the README - update the test badge
- new plugin EP002, checks for misplaced elements with target & proxy endpoints - tests for same
|
Something is very wrong, the PR is showing old commits. I have tried 5 times to create a clean PR, still not succeeding. Deleting this one. Will try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.