Rename :path option #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t key before handing it off to us, shown here: https://github.com/elixir-lang/plug/blob/master/lib/plug/session.ex#L48
Contributor
Author
|
Think we can merge this? |
Owner
|
Oh. Yes. |
Contributor
Author
|
? |
Contributor
Author
|
think you can give me merge access? |
|
@mgwidmann - Forked and published to Hex with your changes. |
Contributor
Author
|
I can publish under the original package on hex.pm, would just prefer I didn't do it off of a branch like this... @aposto Please give me merge access, its been over a year!!!! |
|
👋 @aposto, are you able to merge this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plug is already using it and it drops that key before handing it off to us, shown here: https://github.com/elixir-lang/plug/blob/master/lib/plug/session.ex#L48
Sorry for this issue!